test: add unique identifier for dynatrace_log_metrics metric key
#882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0weinberger
approved these changes
Nov 20, 2025
The metric key for `dynatrace_log_metrics` has to be unique. When running tests in parallel or encountering an error during destroy/cleanup, the metric key may already exist. So, adding `#name#` to the key makes it unique.
d0weinberger
force-pushed
the
test/log-metric-uniqueness
branch
from
d0d9c19 to
4117d55
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
The test for
dynatrace_log_metricscan fail if the metric key already exists (race condition or parallel test executions).What has changed?
A unique identifier is now added to the
dynatrace_log_metricsresource example.How does it do it?
By adding
#name#to the metric key.How is it tested?
Current tests cover it.
How does it affect users?
Doesn't affect users. They will just see a slightly different example.
Issue: