I18n/base #1869
Open
I18n/base #1869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebkr
commented
Aug 1, 2025
| OCULUS_STORE: "Oculus Store", | ||
| ORIGIN: "Origin / EA App", | ||
| XBOX_GAME_PASS: "Xbox Game Pass", | ||
| OTHER: "Autre", |
anttimaki
reviewed
Aug 21, 2025
Collaborator
anttimaki
left a comment
anttimaki
left a comment
There was a problem hiding this comment.
Did you consider the TypeScript approach presented in the docs? Using the main language as the source for types seems like an better option than tracking the types separately & manually. Or does that approach have some benefits?
Aside from that LGTM.
ebkr
force-pushed
the
quasar-upgrade
branch
2 times, most recently
from
0e36b51 to
22c7357
Compare
Closed
ebkr
force-pushed
the
quasar-upgrade
branch
from
777cfe4 to
dad6801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i18n base
This is a PR for barebones i18n support which covers the GameSelectionScreen.vue file.
PR summary
vue-i18nlibrary we've had half setup since the project started 💀Alt+L) to switch between English and French (temporary)Expected work on further PRs
Screenshots
English
French