I18n/manager view #1877
Draft
I18n/manager view #1877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebkr
force-pushed
the
i18n/manager-view
branch
2 times, most recently
from
31384d7 to
b3a13f1
Compare
anttimaki
approved these changes
Aug 21, 2025
| switch (0) { | ||
| case modName.value.trim().length: | ||
| validationMessage.value = "The mod name must not be empty."; |
Collaborator
There was a problem hiding this comment.
Similar to comment in an earlier PR in this stack, would it be clearer if the whole translation key was used here?
| import {PlatformTranslation} from "./platforms/PlatformTranslation"; | ||
| import {ProfileSelectionTranslation} from "./pages/ProfileSelectionTranslation"; | ||
| import {ManagerTranslation} from './pages/ManagerTranslation'; | ||
| import { DateTimeFormat } from 'src/i18n'; |
ebkr
force-pushed
the
i18n/manager-view
branch
from
b3a13f1 to
770e691
Compare
ebkr
force-pushed
the
i18n/manager-view
branch
from
770e691 to
1e7dd5a
Compare
Closed
- Fixed error with using {{ activeGame.displayName }} in translation
- Refactored enums into global translation area. Changed existing references.
- Additionally fixed issues with OnlineModListWithPanel and OnlineModView
…lization in French
ebkr
force-pushed
the
i18n/manager-view
branch
from
1e7dd5a to
5c6f0cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Differences
Launch parameters modal
The text for this has been changed to show as
argumentsinstead ofparametersas this has been an incorrect term for a long time.Code export modal
There was no previous functionality to copy the export code directly.