Add test for missing/pending GoodJob migrations #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoodJob upgrades sometimes include migrations that need to be generated and run. This test alerts us to that fact.
Mr0grog
added a commit
to edgi-govdata-archiving/web-monitoring-ops
that referenced
this pull request
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoodJob upgrades sometimes include migrations that need to be generated and run. This test alerts us to that fact.
This should fail in CI (since we have missing migrations). Embarrassingly, I have had this test sitting around locally for most of a year, and thought it had been committed (my git client is set up to stop getting in my face about old un-added files, and somewhere along the line it stopped alerting me to this because it had been sitting around so long). I’m not sure how this never got committed in the first place, but since I often took more care with testing and examining GoodJob upgrades locally, I never noticed the tests were not failing in CI because I always got the test failure locally.