Improve type safety in defaultsValueFromSchema with generics #561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses type safety feedback on the
defaultsValueFromSchemafunction which was usinganytypes extensively in its signature.Changes
<T = any>and changedschema: S.Schema<any>→S.Schema<T>record: Record<string, any>→Record<string, unknown>any→T | Partial<T> | null | undefinedto accurately reflect actual return valuesunknowntypes needed explicit castingExample
The generic parameter enables better type inference while maintaining backward compatibility through the
T = anydefault.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.