Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 4, 2025

@lcawl lcawl added the chore label Dec 4, 2025
@lcawl lcawl marked this pull request as ready for review December 4, 2025 22:49
@lcawl lcawl requested a review from a team as a code owner December 4, 2025 22:49
@lcawl lcawl requested review from Mpdreamz and marciw December 4, 2025 22:49
@theletterf
Copy link
Contributor

+CC @v1v

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a very tiny comment regarding the alphabetical order

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for following up with this @lcawl ! 🙏

@theletterf
Copy link
Contributor

@Mpdreamz I'm going to comment out the CF GCP blocks for now, since they're making updatecli fail — checked with @constanca-m about this. We can uncomment them back at the end of December.

@Mpdreamz
Copy link
Member

Mpdreamz commented Dec 5, 2025

Thanks for chasing that @theletterf !

@lcawl lcawl enabled auto-merge (squash) December 5, 2025 16:44
@lcawl lcawl merged commit 5a492db into main Dec 5, 2025
28 checks passed
@lcawl lcawl deleted the client-updatecli branch December 5, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants