-
Notifications
You must be signed in to change notification settings - Fork 33
Add clients to updatecli automation #2310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+CC @v1v |
v1v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a very tiny comment regarding the alphabetical order
Mpdreamz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for following up with this @lcawl ! 🙏
|
@Mpdreamz I'm going to comment out the CF GCP blocks for now, since they're making updatecli fail — checked with @constanca-m about this. We can uncomment them back at the end of December. |
|
Thanks for chasing that @theletterf ! |
Relates to #2308 (review)
Per https://docs-v3-preview.elastic.dev/elastic/docs-builder/tree/main/contribute/release-new-version "This action [updating the versions.yml file] can be performed by any member of the docs team. It's also automated for many products".
This PR copies the existing pattern for the clients, which all use releases like this: