Remove DNS probes and associated code #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasberlin
force-pushed
the
nberlin/remove_dns_stuff
branch
from
a024da4 to
7444f5b
Compare
haesbaert
approved these changes
Sep 10, 2025
stanek-michal
approved these changes
Sep 10, 2025
Contributor
stanek-michal
left a comment
stanek-michal
left a comment
There was a problem hiding this comment.
ACK (but check #231 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had previously thought simply disabling DNS probe loading was enough, but I still see customer errors related to
skb_egresseven after loading is disabled.This PR simply removes all the DNS probes and related infrastructure.
Elastic Endpoint use quark for DNS probes, so removing them from here.