Send read receipts using the current timeline, not the live timeline

[jmartinesp]

Content

This fixes sending read receipts in threads.

cc @frebib

Motivation and context

If you opened a thread, previously the app would try to send read receipts for it using the live timeline. As those events aren't really in the live timeline, this would be rejected by the homeserver.

Tests

You'll need 2 clients (EX/EW) with the same account and one with a different account to test it. With threads enabled:

• From another account, send a message in a thread that this client will receive and take as an unread.
• With this client, open such thread.
• From the other client with the same account, check the read receipt is now gone.

Tested devices

• Physical
• Emulator
• OS version(s): 16

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[jmartinesp]

Note there is a similar issue, causing the live timeline to send an incorrect read receipt when the latest event of the room is in a thread even if there were unread events in the live timeline: similarly, it will try sending a read receipt for a threaded event from the live timeline, but as this event is not in this timeline, the HS will reject it. That will be handled in matrix-org/matrix-rust-sdk#5864 instead.

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/R3K3ea

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.63%. Comparing base (7b7c429) to head (8a5cf99).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #5731   +/-   ##
========================================
  Coverage    79.63%   79.63%           
========================================
  Files         2431     2431           
  Lines        65261    65263    +2     
  Branches      8332     8332           
========================================
+ Hits         51972    51974    +2     
  Misses       10308    10308           
  Partials      2981     2981           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bmarty]

Thanks. I suspect that there are other usage of JoinedRoom.liveTimeline with the same problem.
I see:

• NotificationBroadcastReceiverHandler.sendMatrixEvent()
• MediaViewerPresenter.delete()
• Others that I missed?

There is also maybe on opportunity to create an extension like JoinedRoom.getTimeline(ThreadId?), since the code which either returns the liveTimeline or creates one for thread is the same at several places.