-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat(plugin-sql): add ownerId field to Agent with camelCase mapping #6147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @0xbbjoker's task —— View job Code Review Complete ✅Todo List:
✅ APPROVED - Excellent ImplementationThis PR demonstrates high-quality code with comprehensive test coverage. All critical requirements are met: Key Strengths:
Test Coverage Highlights:
Technical Implementation:
No Issues Found:
This is a model implementation that follows all ElizaOS best practices. Ready for merge! 🚀 |
| * It includes: | ||
| * - `enabled`: A boolean indicating if the agent is currently active or disabled. | ||
| * - `status`: The current operational status, typically `AgentStatus.ACTIVE` or `AgentStatus.INACTIVE`. | ||
| * - `ownerId`: Optional UUID of the user/entity that owns this agent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ownerID is not an user or entity.
It is a serverID.
My next PR about entity isolation will change this name. We can merge as is. But if you can change the comment to feat the reality ?
Thanks !
This change improves type safety and follows JavaScript/TypeScript naming
conventions while maintaining backward compatibility with the database schema.
Note
Adds
ownerIdtoAgent, maps DBowner_idto camelCase, updates RLS usage, and adds integration tests for create/update flows.ownerIdtoAgentinpackages/core/src/types/agent.ts.owner_idto camelCaseownerIdinpackages/plugin-sql/src/schema/agent.ts.agent.ownerIdand update assignment writes via{ ownerId: ownerId }inpackages/plugin-sql/src/rls.ts.ownerIdinpackages/plugin-sql/src/__tests__/integration/agent.test.ts.Written by Cursor Bugbot for commit 4697996. This will update automatically on new commits. Configure here.