[mob][photos] Fix mobile app album share link copying #7790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… URL This fixes an intermittent issue where copying an album share link would result in just the hash fragment (e.g., ente-io#1234) being copied instead of the full URL (e.g., https://albums.ente.io/?t=1234#key). Root cause: After building the URL with Uri.replace(), the code attempted to decode IDN domains with string replacement: if (customDomain.isNotEmpty && publicUrl.host.contains('%')) { final decodedHost = Uri.decodeComponent(publicUrl.host); finalUrl = finalUrl.replaceFirst(publicUrl.host, decodedHost); } This string replacement could fail or match incorrectly, corrupting the URL and sometimes leaving only the fragment portion. Fix: Remove the string manipulation entirely. Uri.toString() already handles IDN encoding correctly, so the manual decoding is unnecessary and was causing the corruption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests