Add image block to each service in Helm chart #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephaw1022
changed the title
krumware
requested changes
Oct 10, 2025
Member
krumware
left a comment
krumware
left a comment
There was a problem hiding this comment.
Should we use this instead of repository: bitnamilegacy/{image}?
Also, we can't misrepresent redis by using the valkey image, but I'm happy to accept an addition of a valkey service manifest here!
Author
|
yeah the redis one can be changed real easily! @krumware |
Author
|
one thing that I just noticed is that we could just leverage the public aws ecr instead of dockerhub. Since ecr is just acting as a pull through cache for library and bitnami dockerhub images, the deleted images on dockerhub shouldnt be an issue since theyre not deleted from ecr. @krumware |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #607