Skip to content

Conversation

@starbelly
Copy link
Contributor

Per this comment , erl_call is not very unicode aware, but it will print what is returned in unicode if the -fetch_stdout option is utilized.

This may be tested by generating a release, starting it up, and then running an eval against it like so :

$ _build/default/rel/app/bin/app eval 'io:format("~ts~n",[[257]]).'
ā
ok

Inversely, doing this on main as it is will get you :

_build/default/rel/feedhack/bin/feedhack eval 'io:format("~ts~n",[[257]]).'
ok

@tsloughter
Copy link
Member

Huh, interesting. Any possible repercussions to enabling fetch_stdout?

@garazdawi
Copy link

Any possible repercussions to enabling fetch_stdout?

You get stdout when you don't expect it to be there :D So just as when we changed from nodetool to erl_call we lost things written to stdout, this would now again print those things.

@starbelly
Copy link
Contributor Author

Oh hmm. If relx is supporting versions prior to 24 then this will need to be made conditional.

@tsloughter
Copy link
Member

@garazdawi ah... I guess that is good, but also bad since we told people they weren't getting that, haha.

@starbelly support should just be 28, 27, 26 I think. So Github actions need to be updated.

@starbelly
Copy link
Contributor Author

@starbelly support should just be 28, 27, 26 I think. So Github actions need to be updated.

Updated. Windows test failing, but that seems unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants