ci: centralize ci-package-manager
#342
Merged
+14
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
added
the
accepted
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes the ci-package-manager workflow by migrating from a local implementation to a reusable workflow hosted in the eslint/workflows repository. The workflow was also renamed from ci-build-all-pm.yml to ci-package-manager.yml for better clarity. This aligns with ESLint's ongoing effort to centralize common workflows across repositories (ref: eslint/workflows#4).
Key Changes
- Replaced local 131-line workflow implementation with a reference to centralized reusable workflow
- Renamed workflow file from
ci-build-all-pm.ymltoci-package-manager.yml - Maintained the same trigger conditions (push and pull_request on main branch)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/ci-package-manager.yml |
New workflow file that references the centralized ci-package-manager workflow from eslint/workflows repository |
.github/workflows/ci-build-all-pm.yml |
Deleted old local workflow implementation that tested package installation with npm, Yarn v1, Yarn Modern, pnpm, and bun |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aladdin-add
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've centralized the
ci-package-managerworkflow as part of the effort to centralize workflows (ref: eslint/workflows#4).I renamed the workflow file from
ci-build-all-pmtoci-package-managerto make its purpose clearer.What changes did you make? (Give an overview)
In this PR, I centralized the
ci-package-managerworkflow.Related Issues
Refs: eslint/workflows#25, eslint/workflows#4
Is there anything you'd like reviewers to focus on?
N/A