fix(pattern/parser): allow '_' in name identifiers (#431) #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Owner
|
Excellent work @develatter, and thanks so much for this. Looks like there is a lint change that you'll need to make. Also it looks like i need to decide what to do with indexmap/min rustc version. Once I figure that out I'll have you rebase on my changes. Thanks again! |
Contributor
Author
|
Hello @estk ! I made the lint change, should I make the PR now or wait for you to tell me to do it with your changes rebased on? |
estk
approved these changes
Nov 14, 2025
Add support for the '_' character in the parser's "name" production so identifiers like "thread_id" parse correctly. This updates the pattern parser to treat underscore as a valid name character. Changes: - Modified src/encode/pattern/parser.rs to accept '_' in names. - Updated/added tests related to thread_id and name parsing. No breaking API changes. Related to estk#431.
estk
force-pushed
the
fix-issue-431-thread-id
branch
from
d19bf5f to
33a1d2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the underscore character in the pattern parser's name production so identifiers like
thread_idparse correctly.Root cause
The parser validated identifier characters using only
is_alphanumeric(), which rejects_. That caused parse errors for names containing underscores.Changes
ch == '_'as a valid name character in src/encode/pattern/parser.rs.thread_id.Testing
All updated tests pass locally.
Related to #431