Lower Joi dependency #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BREAKING CHANGE: update to support @hapi/joi v16 * chore: pin to minor versions in deps * fix: bump node types * chore: update licence
exporessJoiValidator => expressJoiValidator
…ortiss#26) * fix: address changes in joi v16 types * chore: bump verison to 4.0.2 * docs: changelog for 4.0.2 * fix: should still extend * fix: remove joi-extract-type temporarily
* fix: address new qs typings in express types
* fix: address new qs typings in express types * [BREAKING CHANGE]: Optional global joi options. Co-authored-by: Evan Shortiss <[email protected]>
danielbrauer
changed the title
Author
|
So it looks like now it doesn't compile with a newer Joi because of that same type no longer being generic? |
Owner
|
@danielbrauer correct, but the reason for this 3.x release is to support joi-extract-type which requires Joi v15. So all Joi deps need to be 15.x variants |
Author
Of course. Reducing those dependencies allows tests to pass here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set Joi peer dependency to 15, and fixed generic type parameter as per #30 (comment)
Also merged
master