-
-
Notifications
You must be signed in to change notification settings - Fork 3
⬆️ Bump the composer group with 5 updates #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps the composer group with 5 updates: | Package | From | To | | --- | --- | --- | | [nikic/php-parser](https://github.com/nikic/PHP-Parser) | `5.6.0` | `5.6.1` | | [symfony/console](https://github.com/symfony/console) | `7.3.2` | `7.3.3` | | [phpstan/phpstan](https://github.com/phpstan/phpstan) | `2.1.21` | `2.1.22` | | [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) | `12.3.0` | `12.3.8` | | [squizlabs/php_codesniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) | `3.13.2` | `3.13.4` | Updates `nikic/php-parser` from 5.6.0 to 5.6.1 - [Release notes](https://github.com/nikic/PHP-Parser/releases) - [Changelog](https://github.com/nikic/PHP-Parser/blob/master/CHANGELOG.md) - [Commits](nikic/PHP-Parser@v5.6.0...v5.6.1) Updates `symfony/console` from 7.3.2 to 7.3.3 - [Release notes](https://github.com/symfony/console/releases) - [Changelog](https://github.com/symfony/console/blob/7.3/CHANGELOG.md) - [Commits](symfony/console@v7.3.2...v7.3.3) Updates `phpstan/phpstan` from 2.1.21 to 2.1.22 - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/2.1.x/CHANGELOG.md) - [Commits](phpstan/phpstan@2.1.21...2.1.22) Updates `phpunit/phpunit` from 12.3.0 to 12.3.8 - [Release notes](https://github.com/sebastianbergmann/phpunit/releases) - [Changelog](https://github.com/sebastianbergmann/phpunit/blob/12.3.8/ChangeLog-12.3.md) - [Commits](sebastianbergmann/phpunit@12.3.0...12.3.8) Updates `squizlabs/php_codesniffer` from 3.13.2 to 3.13.4 - [Release notes](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases) - [Changelog](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/CHANGELOG.md) - [Commits](PHPCSStandards/PHP_CodeSniffer@3.13.2...3.13.4) --- updated-dependencies: - dependency-name: nikic/php-parser dependency-version: 5.6.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: composer - dependency-name: symfony/console dependency-version: 7.3.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: composer - dependency-name: phpstan/phpstan dependency-version: 2.1.22 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: composer - dependency-name: phpunit/phpunit dependency-version: 12.3.8 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: composer - dependency-name: squizlabs/php_codesniffer dependency-version: 3.13.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: composer ... Signed-off-by: dependabot[bot] <[email protected]>
|
I ran the upgrade manually (not sure why dependabot did not run it as it is a monthl check usually). About the infection report, in fact it looks like the PHP-Parser pretty-printing code does not handle the aliases. To me we should at least keep the tests to ensure this behavior remain in the future. But about the normalization code I'm okay to keep or remove it, what do you think about this @mk-mxp ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know more than you do 😄 I'd use XDebug to inspect the object tree in each test case and most likely one will see the non-deprecated form being pretty-printed in every case. Maybe it depends on some PHP target version setting?
Edit: I would keep the normalization code, for documentation. Maybe also mark the false positives so infection ignores them?
|
Yes, indeed, the pretty printer does not produce aliases for |
Thanks for your input, after reflection:
|
I've been thinking of excluding them by infection configuration, which would not "bloat" the code. |
Bumps the composer group with 5 updates:
5.6.05.6.17.3.27.3.32.1.212.1.2212.3.012.3.83.13.23.13.4Updates
nikic/php-parserfrom 5.6.0 to 5.6.1Release notes
Sourced from nikic/php-parser's releases.
Changelog
Sourced from nikic/php-parser's changelog.
Commits
f103601Release PHP-Parser 5.6.1f4097ddFix branch-alias for dev-master (#1101)02dcdd7Avoid deprecated SplObjectStorage::attach/detachf7d2856Add PHP 8.5 to CI4369a74Update phpstan baseline5ad295aAdd cast kinds for bool, int, string (#1098)63114feFix Param::isPublic() for param with asymmetric visibilityUpdates
symfony/consolefrom 7.3.2 to 7.3.3Release notes
Sourced from symfony/console's releases.
Commits
cb0102aMerge branch '6.4' into 7.353a8528bug #61033 [Console] RestoreSHELL_VERBOSITYafter a command is ran (lyrixx)273fd29[Console] Fix testing multiline questiona1e23cfMerge branch '6.4' into 7.3ad2f59f[Console] Restore SHELL_VERBOSITY after a command is ran01edfbaMerge branch '6.4' into 7.30ca45ae[Console][Table] Don't split grapheme clustersUpdates
phpstan/phpstanfrom 2.1.21 to 2.1.22Release notes
Sourced from phpstan/phpstan's releases.
Commits
41600c8PHPStan 2.1.226b2473aUpdated PHPStan to commit 6b2473a801bcde83c014530ba5a702577cdc84786d4e429Update baselines9bde094Updated PHPStan to commit 9bde0940c93c3f7d63fe88ae8f55435aeb19fa15252390fUpdated PHPStan to commit 252390ffd16aaa51fba866a3f8e1b833eedb6071a817abfUpdated PHPStan to commit a817abfc2b58ca351b19b2516215702f28102330ebd55c3Update BACKERS.md9dbff97Updated PHPStan to commit 9dbff97c175250fec9dae1ab12cf0052991ce485e6c14f1Updated PHPStan to commit e6c14f18ea949048f2f257a0769978fc3b3c5a277b66f55removing eloquent/phpstan-phony linkUpdates
phpunit/phpunitfrom 12.3.0 to 12.3.8Release notes
Sourced from phpunit/phpunit's releases.
... (truncated)
Changelog
Sourced from phpunit/phpunit's changelog.
... (truncated)
Commits
9d68c1bPrepare release4beb7f8Merge branch '11.5' into 12.3264a87cPrepare release45bf34dMerge branch '11.5' into 12.35470bdbMerge branch '10.5' into 11.515d0472Also trigger a warning for a data provider method that has a #[Test] attributee9ae90cMove methode9071b4Merge branch '11.5' into 12.3b595dccMerge branch '10.5' into 11.560d0349Merge branch '9.6' into 10.5Updates
squizlabs/php_codesnifferfrom 3.13.2 to 3.13.4Release notes
Sourced from squizlabs/php_codesniffer's releases.
... (truncated)
Changelog
Sourced from squizlabs/php_codesniffer's changelog.
... (truncated)
Commits
ad545eaMerge pull request #1217 from PHPCSStandards/feature/changelog-3.13.4905603eChangelog for the 3.13.4 release288a2a9Merge pull request #1215 from PHPCSStandards/php-8.5/fix-null-as-array-offset...d9b3e66Merge pull request #1213 from PHPCSStandards/feature/remove-filelist-tests6b82a86PHP 8.5 | Tokenizer/PHP: temporarily silence "Using null as an array offset" ...acf2a54PHP 8.5 | Tokenizer/PHP: fix "Using null as an array offset" deprecationc019c75PHP 8.5 | File::getMemberProperties(): fix "Using null as an array offset" de...def8714🔥 Hot Fix: remove FileList testsf1c9394Config: update version nr to next5be16e1Merge pull request #1211 from PHPCSStandards/feature/changelog-3.13.3Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions