-
Notifications
You must be signed in to change notification settings - Fork 156
Add native server deployments support for EAS Update #3155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
krystofwoldrich
wants to merge
7
commits into
main
Choose a base branch
from
@krystofwoldrich/update-command-reload-config-after-assets-upload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add native server deployments support for EAS Update #3155
krystofwoldrich
wants to merge
7
commits into
main
from
@krystofwoldrich/update-command-reload-config-after-assets-upload
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +924 B (0%) Total Size: 53.6 MB
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3155 +/- ##
==========================================
+ Coverage 51.89% 51.91% +0.02%
==========================================
Files 616 616
Lines 24849 24859 +10
Branches 5216 5216
==========================================
+ Hits 12894 12903 +9
- Misses 10883 10884 +1
Partials 1072 1072 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
a026293 to
d18fdd8
Compare
|
✅ Thank you for adding the changelog entry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
EAS Currently supports native deployments only for EAS Builds.
How
This PR relies on Expo CLI changes which deploys API routes for the update during
export, same asexport:embeddeploys them for native builds.eas updatesets__EXPO_GENERATED_CONFIG_PATHwhichexpo exportwrites the generated config into. The deployed URL in this case. This TMP file is created to avoid breaking computed fingerprint. This ensures the new update with will be compatible with the native build or prev update.This PR also passes it's binary using envs to Expo CLI to ensure the executed deploy command uses the same EAS CLI as the update.
Test Plan
Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.
# .env EXPO_UNSTABLE_DEPLOY_SERVER=trueExample output