Skip to content

Conversation

@EvanBacon
Copy link
Contributor

The JS engines that we use with React Native do not support import/export syntax so we essentially offload the changes in this PR to be performed locally on every user's machine. This doesn't fully fix the package since the vendor still has es modules.

@vercel
Copy link

vercel bot commented Sep 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/expoio/vector-icons/am6rgMr9uB6jAP4oXoixApc6Cd3Q
✅ Preview: https://vector-icons-git-evanbacon-update-transpilation-expoio.vercel.app

@brentvatne
Copy link
Member

my only concern about this is that, unless i'm mistaken, there is a minor breaking change -- if someone was, for some reason, using cjs to import a font directly we won't have default anymore:

// This won't work anymore
const AntDesign = require('@expo/vector-icons/AntDesign').default;

@Simek
Copy link
Contributor

Simek commented Jul 13, 2023

@EvanBacon Do we still need this refactor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants