Adding support for unions in Codegen Schema #54489
Open
+2,936
−1,639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arushikesarwani94 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86501597. |
meta-cla
bot
added
the
CLA Signed
Summary: Pull Request resolved: facebook#54489 Previously, the parser was mapping to Array<any> when the element types of union were different. This caused compat checker to not recognize changes in unions of different types. `StringLiteralUnionTypeAnnotation` already had support for `types`, that can be expanded to all Union types so as to incorporate the Unions of different types. ``` { type: 'StringLiteralUnionTypeAnnotation', types: [ { type: 'StringLiteralTypeAnnotation' value: 'light' }, { type: 'StringLiteralTypeAnnotation' value: 'dark' }, ], } ``` NOTE: Generators behavior still remain unchanged hence don't allow unions of different types. Only RN Compat Checker consumes this. The value of this is that the compat checker can now error when the union of different types changes. Also for consistency added support for similar literal types for Number & Boolean i.e `NumberLiteralTypeAnnotation` & `BooleanLiteralTypeAnnotation` Changelog: [Internal] Differential Revision: D86501597
arushikesarwani94
force-pushed
the
export-D86501597
branch
from
ca640fe to
3357a65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, the parser was mapping to Array when the element types of union were different. This caused compat checker to not recognize changes in unions of different types.
StringLiteralUnionTypeAnnotationalready had support fortypes, that can be expanded to all Union types so as to incorporate the Unions of different types.NOTE: Generators behavior still remain unchanged hence don't allow unions of different types. Only RN Compat Checker consumes this.
The value of this is that the compat checker can now error when the union of different types changes.
Changelog: [Internal]
Differential Revision: D86501597