Fix crash by implementing scrollViewDidScroll in RCTEnhancedScrollView #54583
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
gabec
pushed a commit
to gabec/react-native
that referenced
this pull request
Nov 18, 2025
facebook#54583) Summary: Fix crash by implementing the missing `scrollViewDidScroll:` method in `RCTEnhancedScrollView`. ## Root Cause `RCTEnhancedScrollView` conforms to `UIScrollViewDelegate` and adds itself as a delegate to its delegate splitter, but only implements two delegate methods: - `scrollViewWillEndDragging:withVelocity:targetContentOffset:` - `scrollViewDidZoom:` It was missing `scrollViewDidScroll:`, which is the most commonly called delegate method. When the splitter has multiple delegates, it sets itself as the UIScrollView's delegate and forwards messages to all registered delegates. When `UIScrollView` calls `scrollViewDidScroll:` on the splitter, the splitter attempts to forward it to `RCTEnhancedScrollView`, which doesn't implement it → crash: "unrecognized selector sent to instance". ## Solution Implement an empty `scrollViewDidScroll:` method in `RCTEnhancedScrollView`. Reviewed By: cipolleschi Differential Revision: D86813725
gabec
force-pushed
the
export-D86813725
branch
from
4796617 to
657e303
Compare
facebook#54583) Summary: Fix crash by implementing the missing `scrollViewDidScroll:` method in `RCTEnhancedScrollView`. ## Root Cause `RCTEnhancedScrollView` conforms to `UIScrollViewDelegate` and adds itself as a delegate to its delegate splitter, but only implements two delegate methods: - `scrollViewWillEndDragging:withVelocity:targetContentOffset:` - `scrollViewDidZoom:` It was missing `scrollViewDidScroll:`, which is the most commonly called delegate method. When the splitter has multiple delegates, it sets itself as the UIScrollView's delegate and forwards messages to all registered delegates. When `UIScrollView` calls `scrollViewDidScroll:` on the splitter, the splitter attempts to forward it to `RCTEnhancedScrollView`, which doesn't implement it → crash: "unrecognized selector sent to instance". ## Solution Implement an empty `scrollViewDidScroll:` method in `RCTEnhancedScrollView`. ## Changelog [iOS][Fixed] - Fix crash in RCTEnhancedScrollView when scrollViewDidScroll is called Reviewed By: cipolleschi, keoskate Differential Revision: D86813725
gabec
force-pushed
the
export-D86813725
branch
from
657e303 to
52e9ecc
Compare
|
This pull request has been merged in 5f14001. |
Collaborator
|
This pull request was successfully merged by Gabriel Cadden in 5f14001 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix crash by implementing the missing
scrollViewDidScroll:method inRCTEnhancedScrollView.Root Cause
RCTEnhancedScrollViewconforms toUIScrollViewDelegateand adds itself as a delegate to its delegate splitter, but only implements two delegate methods:scrollViewWillEndDragging:withVelocity:targetContentOffset:scrollViewDidZoom:It was missing
scrollViewDidScroll:, which is the most commonly called delegate method. When the splitter has multiple delegates, it sets itself as the UIScrollView's delegate and forwards messages to all registered delegates. WhenUIScrollViewcallsscrollViewDidScroll:on the splitter, the splitter attempts to forward it toRCTEnhancedScrollView, which doesn't implement it → crash: "unrecognized selector sent to instance".Solution
Implement an empty
scrollViewDidScroll:method inRCTEnhancedScrollView.Changelog:
[iOS][Fixed] - Fix crash in RCTEnhancedScrollView when scrollViewDidScroll is called
Reviewed By: cipolleschi
Differential Revision: D86813725