-
Notifications
You must be signed in to change notification settings - Fork 9
docs: fix wrong service providers URL #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix wrong service providers URL #270
Conversation
SgtPooki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaf-lamed-beyt this change does point me to the correct location but there are a lot of whitespace changes. Can you submit this PR without the unnecessary whitespace changes?
|
ah, let me do that now. my bad. that must be prettier doing what it is not supposed to. |
disabled prettier settings for newline and trailing spaces for filecoin-pin in my editor (Zed), and ignore the settings file
|
@kaf-lamed-beyt the change in .gitignore I assume is unintended. Please revert that. Once that is done, the PR should be good to go. |
|
hi @rjan90, it is intended. my editor, Zed, does some formatting unnecessarily to markdown files, so i turned it off specifically for this project by adding a settings file a if i don't do that, this PR would include a couple of unnecessary whitespaces. see this git should not track the file, that's why i included it in |
|
@kaf-lamed-beyt you can always do usually, a .gitignore should only contain the relevant files for a particular project and the standard tools of the maintainers.. while it's probably not harmful, having everyone that commits to a repo add their preferred tools to the It's usually best practice to just not stage & commit changes unless you know they are relevant to a particular repo |
|
@kaf-lamed-beyt also, you can do global git ignore files (and override that for individual repos/folders if you desire), or a local only ignore (no commit needed) for just this repo by doing: > echo ".zed" >> .git/info/exclude |
oh, i get you now. thank you for the feedback, @SgtPooki apologies for not responding on time. i see that you've already removed the line. |
thank you! i'll do this too. |
closes #269