Skip to content

Conversation

@kaf-lamed-beyt
Copy link
Contributor

closes #269

Copy link
Collaborator

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaf-lamed-beyt this change does point me to the correct location but there are a lot of whitespace changes. Can you submit this PR without the unnecessary whitespace changes?

@SgtPooki SgtPooki assigned SgtPooki and kaf-lamed-beyt and unassigned SgtPooki Nov 25, 2025
@kaf-lamed-beyt
Copy link
Contributor Author

ah, let me do that now. my bad.

that must be prettier doing what it is not supposed to.

disabled prettier settings for newline and trailing spaces for filecoin-pin in my editor (Zed), and ignore the settings file
@rjan90
Copy link
Collaborator

rjan90 commented Dec 3, 2025

@kaf-lamed-beyt the change in .gitignore I assume is unintended. Please revert that. Once that is done, the PR should be good to go.

@kaf-lamed-beyt
Copy link
Contributor Author

kaf-lamed-beyt commented Dec 3, 2025

hi @rjan90, it is intended.

my editor, Zed, does some formatting unnecessarily to markdown files, so i turned it off specifically for this project by adding a settings file a .zed/settings.json file, to turn off a couple of the formatting.

if i don't do that, this PR would include a couple of unnecessary whitespaces. see this

git should not track the file, that's why i included it in .gitignore, unless it is okay to have it in the repo, i can remove it from gitignore.

@SgtPooki
Copy link
Collaborator

SgtPooki commented Dec 3, 2025

@kaf-lamed-beyt you can always do git add -p to only stage piece of changes you want to commit before committing, or even do a hunk based staging via many GUI editors.

usually, a .gitignore should only contain the relevant files for a particular project and the standard tools of the maintainers.. while it's probably not harmful, having everyone that commits to a repo add their preferred tools to the .gitignore could result in a very long and unmanageable file where core maintainers may not be aware what/why certain lines exist.

It's usually best practice to just not stage & commit changes unless you know they are relevant to a particular repo

@SgtPooki
Copy link
Collaborator

SgtPooki commented Dec 3, 2025

@kaf-lamed-beyt also, you can do global git ignore files (and override that for individual repos/folders if you desire), or a local only ignore (no commit needed) for just this repo by doing:

> echo ".zed" >> .git/info/exclude

@kaf-lamed-beyt
Copy link
Contributor Author

@kaf-lamed-beyt you can always do git add -p to only stage piece of changes you want to commit before committing, or even do a hunk based staging via many GUI editors.

usually, a .gitignore should only contain the relevant files for a particular project and the standard tools of the maintainers.. while it's probably not harmful, having everyone that commits to a repo add their preferred tools to the .gitignore could result in a very long and unmanageable file where core maintainers may not be aware what/why certain lines exist.

It's usually best practice to just not stage & commit changes unless you know they are relevant to a particular repo

oh, i get you now. thank you for the feedback, @SgtPooki

apologies for not responding on time. i see that you've already removed the line.

@kaf-lamed-beyt
Copy link
Contributor Author

@kaf-lamed-beyt also, you can do global git ignore files (and override that for individual repos/folders if you desire), or a local only ignore (no commit needed) for just this repo by doing:

> echo ".zed" >> .git/info/exclude

thank you! i'll do this too.

@SgtPooki SgtPooki merged commit 2a16a47 into filecoin-project:master Dec 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage provider URL in glossary.md returns a 404

3 participants