-
Notifications
You must be signed in to change notification settings - Fork 219
add authcontxt params to the DatabaseEvent object #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @kushalpalesha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces significant enhancements to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds authId and authType to the DatabaseEvent interface, allowing developers to access user authentication information in Realtime Database triggers. The changes are correct and include an initial test for onValueWritten. My feedback focuses on improving test coverage and robustness to ensure high quality for this new feature.
| it("should pass auth context into the event", async () => { | ||
| const raw = { | ||
| ...RAW_RTDB_EVENT, | ||
| authId: "uid", | ||
| authType: "unauthenticated", | ||
| }; | ||
|
|
||
| const func = database.onValueWritten("foo/bar", (event) => { | ||
| expect(event.authId).to.equal("uid"); | ||
| expect(event.authType).to.equal("unauthenticated"); | ||
| }); | ||
|
|
||
| await func(raw as any); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new test correctly verifies that the auth context is passed to the onValueWritten handler. However, this change also affects onValueCreated, onValueUpdated, and onValueDeleted as they all use the DatabaseEvent type. It would be beneficial to add similar tests for these other functions to ensure the auth context is passed through correctly for all database trigger types. This would increase confidence in the change across the entire API surface.
Description
Add authctxt fields so users can access them in their v2 functions.
Code sample