chore: Remove Swift suffix from performance

[ncooke3]

• QS– cleanup Swift suffixes (including infra)
  • FIS (chore: Remove Swift suffix from installations #1797)
  • FIAM (chore: Remove Swift suffix from fiam #1798)
  • Perf (chore: Remove Swift suffix from performance #1799)
  • RTDB
  • Others?
  • Infra
  • Residual Swift suffixes scattered throughout xcodeproj files
• FB– cleanup Swift suffixes (including infra)
• Remove PINNED_RUN_ID: '17965877651' and manual references to nc/quickstarts
• Remove Gemfile trigger
• Testing team onboarding
• Merge both branches to main in quickstart and firebase repos
  • Mark Restore Crashlytics Swift test to zip GHA workflow firebase-ios-sdk#8057 as closed
• Re-usable workflows for zip

Follow-up work

• Migrate away from Ruby Xcodeproj (make an issue pot.)

[gemini-code-assist]

Summary of Changes

Hello @ncooke3, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on standardizing the naming within the PerformanceExample Xcode project by removing the 'Swift' suffix from the primary application and UI test targets. This change streamlines the project's internal naming conventions, making them more generic, and is complemented by the introduction of new Xcode schemes to ensure the project remains fully functional and testable under the updated names.

Highlights

• Project Renaming: The main application target and UI test target names within the Xcode project have been updated, removing the 'Swift' suffix. Specifically, 'PerformanceExampleSwift' is now 'PerformanceExample', and 'PerformanceExampleSwiftUITests' is now 'PerformanceExampleUITests'.
• Xcode Project File Updates: Numerous internal references within the project.pbxproj file were modified to reflect the new naming convention for targets, products, and build configurations, ensuring consistency across the project.
• New Xcode Schemes: Two new Xcode schemes, PerformanceExample.xcscheme and PerformanceExampleUITests.xcscheme, were added. These schemes are essential for properly building, running, and testing the renamed application and UI test targets.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/performance.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to remove the Swift suffix from the performance example project. The changes correctly update many references in the Xcode project file and add new schemes with the updated names. However, I've noticed a couple of productName properties that were missed. I've left suggestions to update them for consistency. Additionally, for better long-term maintainability, you might consider also renaming the source directories and files (e.g., PerformanceExampleSwift, PerformanceExampleSwiftUITests.swift) to match the new target names. This could be done in a follow-up PR if it's out of scope for this one.

[gemini-code-assist]

The productName still includes the Swift suffix. To be consistent with the goal of this PR, it should be removed.

            name = PerformanceExampleUITests;
            productName = PerformanceExampleUITests;
            productReference = 107347C420315A61004A66D1 /* PerformanceExampleUITests.xctest */;

[gemini-code-assist]

The productName still includes the Swift suffix. It should be removed to align with the other renames in this file.

            name = PerformanceExample;
            productName = PerformanceExample;
            productReference = 5F5A53791ADE67D500F81DF0 /* PerformanceExample.app */;

[ncooke3]

/gemini review

[gemini-code-assist]

Code Review

This pull request aims to remove the Swift suffix from the performance example project as part of a larger cleanup effort. The changes correctly update many references in the Xcode project file and add new, correctly named schemes. The modifications to scripts/test.sh are also positive, improving its behavior in CI environments. However, I've identified a couple of inconsistencies in the project.pbxproj file where productName values were not updated along with their corresponding target name, which I've left comments on.

[gemini-code-assist]

While the target name was updated to remove the Swift suffix, the productName on the next line was not. For consistency and to avoid confusion, productName should also be updated.

            name = PerformanceExampleUITests;
            productName = PerformanceExampleUITests;

[gemini-code-assist]

Similar to the previous comment, the target name was updated to remove the Swift suffix, but the productName on the next line was not. This should also be updated for consistency.

            name = PerformanceExample;
            productName = PerformanceExample;