-
Notifications
You must be signed in to change notification settings - Fork 0
addition of documentation #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
randallkanna
wants to merge
2
commits into
master
Choose a base branch
from
adding-documentation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,17 +2,44 @@ | |
|
|
||
| Basic tabbed interface. | ||
|
|
||
| ## How to use | ||
| ## Usage | ||
|
|
||
| * Include the latest version in your `package.json`. | ||
| * Components render buttons that will control their associated content. | ||
| * Pass in a `target`, which is the id of the associated content element. | ||
| * `on-click="setCurrentTab"` is required as the action will bubble up in your application. | ||
| * `currentTab=currentTab` is required as your app will pass in the current tab information back to the component. | ||
| * Include the action, `setCurrentTab`, in your actions hash (controller) to set the current tab. | ||
| * `setCurrentTab(tab) { this.set('currentTab', tab); }` | ||
| This Ember addon provides a `ui-tab` component. | ||
|
|
||
| ## Options | ||
| Pass in a target which is the ID of the associated element. Current tab is required as your app will pass in the current tab information back to the component. | ||
|
|
||
| * You can specify the default content by passing in `default=true`. | ||
| * i.e. `{{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#id" default=true}}Button1{{/ui-tab}}` | ||
| **Example:** | ||
| Template: | ||
|
|
||
| ```hbs | ||
| <div class="container"> | ||
| {{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#tab-one" default=true}}Tab One{{/ui-tab}} | ||
| {{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#tab-two"}}Tab Two{{/ui-tab}} | ||
| {{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#tab-three"}}Tab Three{{/ui-tab}} | ||
| {{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#tab-four"}}Tab Four{{/ui-tab}} | ||
| </div> | ||
|
|
||
| <p id="tab-one">Tab One</p> | ||
| <p id="tab-two">Tab Two</p> | ||
| <p id="tab-three">Tab Three</p> | ||
| <p id="tab-four">Tab Four</p> | ||
| ``` | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove extra line |
||
| Include the action 'setCurrentTab' in your controller to set the current tab. | ||
|
|
||
| Controller: | ||
| ```javascript | ||
| import Ember from 'ember'; | ||
|
|
||
| export default Ember.Controller.extend({ | ||
| actions: { | ||
| setCurrentTab(tab) { | ||
| this.set('currentTab', tab); | ||
| } | ||
| } | ||
| }); | ||
| ``` | ||
|
|
||
| ## Styles | ||
|
|
||
| The component `ui-tab` component is easily customizable for your application. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. extra line above |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,11 @@ | ||
| <h2 id="title">FireFly Tabs</h2> | ||
|
|
||
| <div class="container"> | ||
| {{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#new-york" default=true}}New York{{/ui-tab}} | ||
| {{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#los-angeles"}}Los Angeles{{/ui-tab}} | ||
| {{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#chicago"}}Chicago{{/ui-tab}} | ||
| {{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#san-francisco"}}San Francisco{{/ui-tab}} | ||
| {{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#tab-one" default=true}}Tab One{{/ui-tab}} | ||
| {{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#tab-two"}}Tab Two{{/ui-tab}} | ||
| {{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#tab-three"}}Tab Three{{/ui-tab}} | ||
| {{#ui-tab on-click="setCurrentTab" currentTab=currentTab target="#tab-four"}}Tab Four{{/ui-tab}} | ||
| </div> | ||
|
|
||
| <hr> | ||
|
|
||
| <p id="new-york">Financial</p> | ||
| <p id="los-angeles">Hollywood</p> | ||
| <p id="chicago">Chiraq</p> | ||
| <p id="san-francisco">Tech</p> | ||
| <p id="tab-one">Tab One</p> | ||
| <p id="tab-two">Tab Two</p> | ||
| <p id="tab-three">Tab Three</p> | ||
| <p id="tab-four">Tab Four</p> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra line above