L2 Cleanup #58
Open
L2 Cleanup #58
+12
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhulbert
force-pushed
the
l2-cleanup
branch
from
0ddbc2f to
8c1e831
Compare
Member
Author
|
This is ready for testing/review now. It shouldn't alter the behavior of the image in any way |
0x416e746f6e
approved these changes
Dec 11, 2025
| # build op-rbuilder | ||
|
|
||
| if [ -f "l2/_op_rbuilder/mkosi.extra/usr/bin/op-rbuilder" ]; then | ||
| if [ -f "$SRCDIR/l2/_op_rbuilder/mkosi.extra/usr/bin/op-rbuilder" ]; then |
Member
There was a problem hiding this comment.
suggestion:
let's ditch all these if-elses whatsoever (they are no longer needed).
| mkosi-chroot chmod 0750 /etc/vault-agent/gomplate | ||
| mkosi-chroot sh -c "chmod 0640 /etc/vault-agent/gomplate/*" | ||
|
|
||
| # Create /etc/sysconfig for vault-agent |
Member
There was a problem hiding this comment.
suggestion:
this is not only for vault-agent, but for any systemd service that will need some secrets injected via env var.
Suggested change
| # Create /etc/sysconfig for vault-agent | |
| # Create /etc/sysconfig secrets injection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some review comments I left on the
trunk/l2branch