Add separate FilterQuality parameter to RotatedOverlayImage #2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows setting a separate
FilterQuality(and more importantlynull) on theTransformwidget instead of using the samefilterQualityas used on theImageforRotatedOverlayImage. I believe this was an oversight introduced by this change: 2e64369This fixes a problem we encountered. When zooming the rotated image sometimes flickers. My guess is that this happens because the rotated image is raster cached (due to
filterQualitynot being null see: flutter/flutter#106006 (comment)) and when the raster cache gets full (due to tiles coming in) the rotated image is somehow purged from the cache.Demo of the bug:
FlickeringImage.mp4