BadUSB: Full USB/BLE parameter customization, UI improvements, and more #4136
Conversation
WillyJL
requested review from
DrZlo13,
gsurkov,
hedger,
nminaylov and
skotopes
as code owners
| @@ -0,0 +1,325 @@ | |||
| #include "ble_hid_service.h" | |||
|
|
|||
| // Based on <lib/ble_profile/extra_services/hid_service.c> | |||
There was a problem hiding this comment.
Why create a new version of it? Why not just update the ble_profile version?
There was a problem hiding this comment.
mostly due to API. it would be a breaking change, but also i was under the impression that it is preferred for app developers to keep the [app prefix] [flipper name] and xor'ed default mac conventions.
if thats not the case, sure this can be added to the default profile. maybe not as a replacement, but provide a way to choose if you want to just provide prefix + mac xor, or full parameter customization.
There was a problem hiding this comment.
i changed it to be a wrapper profile: it uses the profile from API, but changes name, mac etc... after the base HID profile is setup. imo this is a solid compromise, keeps API the same, and app authors could use this easily if they want more options for HID profile config.
if instead you feel it would be better to provide these extra parameters in API, let me know and i can change it; if so, also not sure if in that case it would be best to change the base profile, or provide a second "thin" profile (like this wrapper) with same logic but different parameters. the second option would mean no API break.
applications/main/bad_usb/scenes/bad_usb_scene_config_usb_vidpid.c
Outdated
Show resolved
Hide resolved
hedger
added
USB
| variable_item_set_current_value_index(item, ble_hid_cfg->pairing); | ||
| variable_item_set_current_value_text(item, ble_pairing_names[ble_hid_cfg->pairing]); | ||
|
|
||
| variable_item_list_add(var_item_list, "BLE Device Name", 0, NULL, NULL); |
There was a problem hiding this comment.
We can omit BLE from item names since they all are only available in BLE pairing mode
There was a problem hiding this comment.
"Remove BLE Pairing" too?
3 participants
What's new
BLE_IDandBT_ID(alias for backwards compatibility), similar toIDcommand but they set BLE MAC address and device nameID,BLE_IDandBT_IDcommands will automatically switch connection mode to their own (if user had selected USB mode, opening a script withBLE_IDcommand will switch to BLE mode on first open), can be changed after opening script of courseVerification
BLE_ID 11:22:33:44:55:AA Test123command and see different values usedID/BLE_ID/BT_IDare not saved to user config)IDandBLE_ID/BT_IDcommandChecklist (For Reviewer)