adding the crossword_companion sample #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesn't support out of the box!
…he tool that uses the API.
redbrogdon
requested changes
Nov 10, 2025
Contributor
redbrogdon
left a comment
redbrogdon
left a comment
There was a problem hiding this comment.
Just a couple quick nits. Do you mind also adding a license header to each code file (e.g. https://github.com/flutter/demos/blob/main/compass_25/lib/model/activity.dart).
There's a single LICENSE file for the repo, so you don't need to add one here.
crossword_companion/README.md
Outdated
|
|
||
| ### Prerequisites | ||
|
|
||
| - A Firebase project. |
Contributor
There was a problem hiding this comment.
Can this link to Firebase's docs for creating one? Also, add a note that the project needs Generative AI to be turned on (and possibly link to that doc as well).
crossword_companion/deploy.sh
Outdated
| @@ -0,0 +1,4 @@ | |||
| flutter clean | |||
Contributor
There was a problem hiding this comment.
I'd leave this file out.
…for the JSON result of the clue solving process.
Contributor
Author
|
I believe all of the feedback has been addressed, but please double-check me. |
redbrogdon
approved these changes
Nov 11, 2025
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist