lib/libifconfig: Fix pointer-sign warnings #1850
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kprovost
reviewed
Sep 19, 2025
Contributor
kprovost
left a comment
kprovost
left a comment
There was a problem hiding this comment.
I found at least one build failure during make universe.
I'm re-building with a fix and if that works I'll push this.
gmshake
suggested changes
Sep 19, 2025
markjdb
reviewed
Sep 19, 2025
Fix all pointer-sign warnings generated when compiling libifconfig. One of these warnings comes from the misuse of snl_add_msg_attr_string for a byte array. Though userland treats carpr_key as a string, it is actually an array of bytes. Handle it as such in libifconfig. While here, fix a small consistency nit in ifconfig_sfp_get_sfp_dump. Signed-off-by: Ryan Moeller <[email protected]>
ryan-moeller
force-pushed
the
libifconfig-warnings
branch
from
6ce6c69 to
54f6f01
Compare
Author
|
I've updated the change in libifconfig_carp.c to treat carpr_key as bytes rather than a string. This fixes the pointer-sign warning and enables future work to properly hash the key in ifconfig, probably using an alternative CARP parameter to avoid breaking the current pass parameter behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all pointer-sign warnings generated when compiling libifconfig.
One of these warnings comes from the misuse of snl_add_msg_attr_string for a byte array. Though userland treats carpr_key as a string, it is actually an array of bytes. Handle it as such in libifconfig.
While here, fix a small consistency nit in ifconfig_sfp_get_sfp_dump.
This eliminates all warnings in libifconfig, and may be trivially backported.
The server with my keys is packed away in storage, so I'd appreciate someone committing this small fix for me.