feat: Add and initialize common CV registers #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the most common CV registers to the project and initializes them with standard default values as specified by the NMRA. This provides a more robust and standards-compliant default configuration for the decoder. The following changes were made: - Added and initialized CVs for consist addressing, function control, and other common features. - Updated existing CVs to align with NMRA standards where they differed. - Improved readability by using decimal values for CVs and adding descriptive comments.
Owner
|
The values are deliberately written as binary, also it looks like some of the default value comments are removed. Additionally some of the CVs are not implemented so i think this would cause more confusion than clarity. Take "1, //CV_28 - RailCom Configuration - Default: RailCom enabled" as an example, railcom is not implemented at all. I get what you were trying to do here, its just that i dont think it improves clarity or readability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the most common CV registers to the project and initializes them with standard default values as specified by the NMRA. This provides a more robust and standards-compliant default configuration for the decoder.
The following changes were made: