Remove nclasses and mode from symbologyState for categorized symbology
#1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
mfisher87
changed the title
mfisher87
changed the title
mfisher87
changed the title
nclasses and mode from symbologyState for categorized symbology
Member
|
Thanks for the PR! Any thoughts on the integration test failure? It doesn't seem related to this change. 🤔 |
Contributor
Author
Currently I have no clue about Test failure. I also ping you about this on zulip |
Member
|
Tests passing on main again 🎉 Rebasing, hope you don't mind :) |
mfisher87
approved these changes
Dec 5, 2025
Member
|
Thanks, Nakul :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing nclasses and mode from symbologyState because it makes tough to use user selected min and max values in pr #912.
Closes #1028
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--1029.org.readthedocs.build/en/1029/
💡 JupyterLite preview: https://jupytergis--1029.org.readthedocs.build/en/1029/lite