Skip to content

Revert "ref(http): Expose all routes temporarily even with internal ports" #5364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

Revert "ref(http): Expose all routes temporarily even with internal ports" #5364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion relay-server/src/endpoints/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ pub fn internal_routes(_: &Config) -> Router<ServiceState>{
/// Relay's public routes.
///
/// Routes which are public API and must be exposed.
#[expect(unused, reason = "temporarily unused")]
pub fn public_routes(config: &Config) -> Router<ServiceState> {
// Exclude internal routes, they must be configured separately.
public_routes_raw(config).route("/api/relay/{*not_found}", any(statics::not_found))
Expand Down
2 changes: 1 addition & 1 deletion relay-server/src/services/server/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ impl Service for HttpServer {
relay_statsd::metric!(counter(RelayCounters::ServerStarting) += 1);

if let Some(internal_listener) = internal_listener {
let public = make_app(service.clone(), crate::endpoints::all_routes);
let public = make_app(service.clone(), crate::endpoints::public_routes);
let internal = make_app(service, crate::endpoints::internal_routes);

tokio::try_join!(
Expand Down
Loading