feat(ourlogs): Add event.name to otlp logs transform
#5396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Nov 20, 2025
Member
jjbayer
left a comment
jjbayer
left a comment
There was a problem hiding this comment.
I would add the event name to one of the test cases in otel_to_sentry. Apart from that, LGTM!
relay-ourlogs/src/otel_to_sentry.rs
Outdated
| trace_id, | ||
| span_id, | ||
| event_name, | ||
| .. |
Member
There was a problem hiding this comment.
Any other fields hidden in .. that why might want to transform? I personally like listing all the unused fields as foo: _ to highlight that we ignore them deliberately.
Member
Author
There was a problem hiding this comment.
the other fields don't have any value, but it's a good point to write them out as unused. Changed in 7e8f349
Dav1dde
approved these changes
Nov 20, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OTEL spec specifies a
EventNamefield on logs: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.46.0/specification/logs/data-model.md#field-eventnameThis is specced as
event.namein our conventions: https://github.com/getsentry/sentry-conventions/blob/main/model/attributes/event/event__name.json.Right now we don't grab this field from the OTLP schema, which is unexpected behaviour as users would expect this field to show up in the logs. This PR updates the OTLP logs transform to set
event.name.