Improve iOS crash reports by adding scope data #491
Merged
+33
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| // 1. Write a crash report to disk with ALL synced scope data | ||
| // 2. Include tags, user, context, breadcrumbs, etc. | ||
| // 3. The crash will be sent on next app launch | ||
| handler.invoke(throwable.asNSException()) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
There was a problem hiding this comment.
yes will have a look
Contributor
Author
There was a problem hiding this comment.
yup we should keep it as true
romtsn
reviewed
Dec 2, 2025
Co-authored-by: Roman Zavarnitsyn <[email protected]>
...src/appleMain/kotlin/io/sentry/kotlin/multiplatform/nsexception/SentryUnhandledExceptions.kt
Show resolved
Hide resolved
...src/appleMain/kotlin/io/sentry/kotlin/multiplatform/nsexception/SentryUnhandledExceptions.kt
Show resolved
Hide resolved
Contributor
Author
|
Will merge this once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this will mess up issue grouping because it
adds some frames to the stacktrace as wellproperly symbolicates the stacktace now but I think it's fine since it's such a big improvement📜 Description
Improve crash handling for iOS/macOS
💡 Motivation and Context
Closes #477
Previously iOS crashes were not synced with scope data.
In cocoa
sentrycrashreport_writeStandardReporttakes care of writing a crash report to disk which includes all the scope data (which was held in C memory). Executing the crashReporter handler invokes this process.💚 How did you test it?
Only manually (comparisons below). This test case would need a proper e2e setup that can reliably report crashes e.g via maestro perhaps
We can put writing this e2e test into an issue and do it when we have time
Event links
Images
With synced scope data:
Without synced scope data:
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps