Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/update-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
cocoa:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-cocoa.sh
name: Cocoa SDK
Comment on lines 9 to 15
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The updater@v3 action is incorrectly called at the job level, causing workflow execution to fail.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The workflow uses uses: getsentry/github-workflows/.github/workflows/updater.yml@v3 at the job level, which is incorrect for v3 of the updater action. v3 is a Composite Action and must be called within a steps block. The current syntax is for reusable workflows, which v3 is not. This structural mismatch will cause GitHub Actions to fail execution for both cocoa and java jobs.

💡 Suggested Fix

Refactor the cocoa and java jobs to include a runs-on property at the job level and a steps block, calling uses: getsentry/github-workflows/updater@v3 within a step.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/update-deps.yml#L9-L15

Potential issue: The workflow uses `uses:
getsentry/github-workflows/.github/workflows/updater.yml@v3` at the job level, which is
incorrect for `v3` of the `updater` action. `v3` is a Composite Action and must be
called within a `steps` block. The current syntax is for reusable workflows, which `v3`
is not. This structural mismatch will cause GitHub Actions to fail execution for both
`cocoa` and `java` jobs.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6029038

Expand All @@ -18,7 +18,7 @@ jobs:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

java:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-java.sh
name: Java SDK
Expand Down