-
-
Notifications
You must be signed in to change notification settings - Fork 62
fix: Screenshot capture in non-main thread setting #2392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bitsandfoxes
wants to merge
12
commits into
main
Choose a base branch
from
fix/screenshot-capture-nonmainthread
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/getsentry/sentry-unity into fix/screenshot-capture-nonmainthread
mujacica
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2387
Unity does not permit the start of coroutines outside the main thread. When inside a burst job, this will actually cause a crash.
The changes here do not just prevent the crash but also enable the SDK to capture a screenshot when an event gets captured on a background thread.
This is achieved by checking whether the current thread is the main thread and if not, "enqueuing" the coroutine to be invoked on the next frame.
I'll follow up on the docs with the limitation of capturing the screenshot on the next frame. The fact that an event is not coming from the main thread is on the issue itself, see