add and update tests

Author: nikkikapadia

static/app/views/alerts/rules/metric/edit.spec.tsx

@@ -267,7 +267,7 @@ describe('MetricRulesEdit', () => {
     ).toBeInTheDocument();
   });
 
-  it('preserves SERVER_WEIGHTED extrapolation mode when editing and saving', async () => {
+  it('changes SERVER_WEIGHTED extrapolation mode to UNKNOWN when editing and saving', async () => {
     const {organization, project} = initializeOrg();
     const ruleWithExtrapolation = MetricRuleFixture({
       id: '5',
@@ -317,7 +317,7 @@ describe('MetricRulesEdit', () => {
       '/organizations/org-slug/events-stats/',
       expect.objectContaining({
         query: expect.objectContaining({
-          extrapolationMode: 'serverOnly',
+          extrapolationMode: 'sampleWeighted',
           sampling: SAMPLING_MODE.NORMAL,
         }),
       })
@@ -335,14 +335,14 @@ describe('MetricRulesEdit', () => {
       expect.anything(),
       expect.objectContaining({
         data: expect.objectContaining({
-          extrapolationMode: ExtrapolationMode.SERVER_WEIGHTED,
+          extrapolationMode: ExtrapolationMode.UNKNOWN,
         }),
         method: 'PUT',
       })
     );
   });
 
-  it('preserves NONE extrapolation mode when editing and saving', async () => {
+  it('changes NONE extrapolation mode to UNKNOWN when editing and saving', async () => {
     const {organization, project} = initializeOrg();
     const ruleWithNoExtrapolation = MetricRuleFixture({
       id: '6',
@@ -392,8 +392,8 @@ describe('MetricRulesEdit', () => {
       '/organizations/org-slug/events-stats/',
       expect.objectContaining({
         query: expect.objectContaining({
-          extrapolationMode: 'none',
-          sampling: SAMPLING_MODE.HIGH_ACCURACY,
+          extrapolationMode: 'sampleWeighted',
+          sampling: SAMPLING_MODE.NORMAL,
         }),
       })
     );
@@ -410,7 +410,7 @@ describe('MetricRulesEdit', () => {
       expect.anything(),
       expect.objectContaining({
         data: expect.objectContaining({
-          extrapolationMode: ExtrapolationMode.NONE,
+          extrapolationMode: ExtrapolationMode.UNKNOWN,
         }),
         method: 'PUT',
       })

static/app/views/alerts/rules/metric/ruleConditionsForm.spec.tsx

@@ -7,6 +7,7 @@ import {
   AlertRuleComparisonType,
   Dataset,
   EventTypes,
+  ExtrapolationMode,
 } from 'sentry/views/alerts/rules/metric/types';
 import type {AlertType} from 'sentry/views/alerts/wizard/options';
 
@@ -111,4 +112,31 @@ describe('RuleConditionsForm', () => {
       )
     ).toBeInTheDocument();
   });
+
+  it('renders extrapolation mode warning', async () => {
+    render(
+      <RuleConditionsForm
+        {...props}
+        eventTypes={[EventTypes.TRACE_ITEM_SPAN]}
+        dataset={Dataset.EVENTS_ANALYTICS_PLATFORM}
+        extrapolationMode={ExtrapolationMode.SERVER_WEIGHTED}
+        organization={organization}
+        router={router}
+        isLowConfidenceChartData
+      />,
+      {
+        organization: {
+          ...organization,
+          features: ['search-query-builder-alerts', 'visibility-explore-view'],
+        },
+      }
+    );
+
+    await screen.findByPlaceholderText(
+      'Filter transactions by URL, tags, and other properties\u2026'
+    );
+    expect(
+      screen.getByText(/This chart may look different from the alert details chart./)
+    ).toBeInTheDocument();
+  });
 });

static/app/views/alerts/rules/metric/ruleForm.spec.tsx

@@ -18,6 +18,7 @@ import {
   AlertRuleSensitivity,
   Dataset,
   EventTypes,
+  ExtrapolationMode,
 } from 'sentry/views/alerts/rules/metric/types';
 
 jest.mock('sentry/actionCreators/indicator');
@@ -711,6 +712,45 @@ describe('Incident Rules Form', () => {
       );
     });
 
+    it('changes extrapolation mode when editing migrated transaction alert rule', async () => {
+      organization.features = [
+        ...organization.features,
+        'performance-view',
+        'visibility-explore-view',
+        'discover-saved-queries-deprecation',
+      ];
+      const metricRule = MetricRuleFixture();
+      createWrapper({
+        rule: {
+          ...metricRule,
+          aggregate: 'count(span.duration)',
+          eventTypes: ['trace_item_span'],
+          dataset: 'events_analytics_platform',
+          extrapolationMode: ExtrapolationMode.SERVER_WEIGHTED,
+        },
+        ruleId: rule.id,
+      });
+
+      await userEvent.click(screen.getByLabelText('Save Rule'));
+
+      expect(editRule).toHaveBeenLastCalledWith(
+        expect.anything(),
+        expect.objectContaining({
+          data: expect.objectContaining({
+            aggregate: 'count(span.duration)',
+            dataset: 'events_analytics_platform',
+            eventTypes: ['trace_item_span'],
+            id: '4',
+            name: 'My Incident Rule',
+            projects: ['project-slug'],
+            query: '',
+            queryType: 1,
+            extrapolationMode: ExtrapolationMode.UNKNOWN,
+          }),
+        })
+      );
+    });
+
     it('switches from percent change to count', async () => {
       createWrapper({
         ruleId: rule.id,

static/app/views/alerts/rules/metric/triggers/chart/index.spec.tsx

@@ -9,6 +9,7 @@ import {
   AlertRuleComparisonType,
   AlertRuleThresholdType,
   Dataset,
+  ExtrapolationMode,
 } from 'sentry/views/alerts/rules/metric/types';
 import {SAMPLING_MODE} from 'sentry/views/explore/hooks/useProgressiveQuery';
 import {TraceItemDataset} from 'sentry/views/explore/types';
@@ -260,4 +261,53 @@ describe('Incident Rules Create', () => {
       })
     );
   });
+
+  it('uses unknown extrapolation mode for editing a migrated alert', async () => {
+    const {organization, project, router} = initializeOrg();
+
+    render(
+      <TriggersChart
+        theme={theme}
+        api={api}
+        location={router.location}
+        organization={organization}
+        projects={[project]}
+        query=""
+        timeWindow={1}
+        aggregate="count(span.duration)"
+        dataset={Dataset.EVENTS_ANALYTICS_PLATFORM}
+        triggers={[]}
+        environment={null}
+        comparisonType={AlertRuleComparisonType.COUNT}
+        resolveThreshold={null}
+        thresholdType={AlertRuleThresholdType.BELOW}
+        newAlertOrQuery
+        onDataLoaded={() => {}}
+        isQueryValid
+        showTotalCount
+        traceItemType={TraceItemDataset.SPANS}
+        extrapolationMode={ExtrapolationMode.NONE}
+      />
+    );
+
+    expect(await screen.findByTestId('area-chart')).toBeInTheDocument();
+    expect(await screen.findByTestId('alert-total-events')).toBeInTheDocument();
+
+    expect(eventStatsMock).toHaveBeenCalledWith(
+      expect.anything(),
+      expect.objectContaining({
+        query: {
+          interval: '1m',
+          project: [2],
+          query: '',
+          statsPeriod: '14d',
+          yAxis: 'count(span.duration)',
+          referrer: 'api.organization-event-stats',
+          dataset: 'spans',
+          sampling: SAMPLING_MODE.NORMAL,
+          extrapolationMode: 'sampleWeighted',
+        },
+      })
+    );
+  });
 });