add conditon to util

Author: nikkikapadia

static/app/views/alerts/rules/metric/details/body.tsx

@@ -39,7 +39,10 @@ import type {Anomaly, Incident} from 'sentry/views/alerts/types';
 import {AlertRuleStatus} from 'sentry/views/alerts/types';
 import {alertDetailsLink} from 'sentry/views/alerts/utils';
 import {DEPRECATED_TRANSACTION_ALERTS} from 'sentry/views/alerts/wizard/options';
-import {getAlertTypeFromAggregateDataset} from 'sentry/views/alerts/wizard/utils';
+import {
+  getAlertTypeFromAggregateDataset,
+  getTraceItemTypeForDatasetAndEventType,
+} from 'sentry/views/alerts/wizard/utils';
 
 import type {TimePeriodType} from './constants';
 import {SELECTOR_RELATIVE_PERIODS} from './constants';
@@ -110,7 +113,7 @@ export default function MetricDetailsBody({
     );
   }
 
-  const {dataset, aggregate, query} = rule;
+  const {dataset, aggregate, query, eventTypes, extrapolationMode} = rule;
 
   const eventType = extractEventTypeFilterFromRule(rule);
   const queryWithTypeFilter =
@@ -143,9 +146,12 @@ export default function MetricDetailsBody({
   const deprecateTransactionsAlertsWarning =
     ruleType && DEPRECATED_TRANSACTION_ALERTS.includes(ruleType);
 
+  const traceItemType = getTraceItemTypeForDatasetAndEventType(dataset, eventTypes);
+
   const showExtrapolationModeWarning = getIsMigratedExtrapolationMode(
-    rule.extrapolationMode,
-    rule.dataset
+    extrapolationMode,
+    dataset,
+    traceItemType
   );
 
   return (

static/app/views/alerts/rules/metric/details/utils.tsx

@@ -17,6 +17,7 @@ import {
 import {extractEventTypeFilterFromRule} from 'sentry/views/alerts/rules/metric/utils/getEventTypeFilter';
 import {isCrashFreeAlert} from 'sentry/views/alerts/rules/metric/utils/isCrashFreeAlert';
 import type {Incident} from 'sentry/views/alerts/types';
+import {TraceItemDataset} from 'sentry/views/explore/types';
 
 /**
  * Retrieve start/end date of a metric alert incident for the events graph
@@ -130,10 +131,12 @@ export function getViableDateRange({
 
 export function getIsMigratedExtrapolationMode(
   extrapolationMode: ExtrapolationMode | undefined,
-  dataset: Dataset
+  dataset: Dataset,
+  traceItemType: TraceItemDataset | undefined | null
 ) {
   return !!(
     dataset === Dataset.EVENTS_ANALYTICS_PLATFORM &&
+    traceItemType === TraceItemDataset.SPANS &&
     extrapolationMode &&
     (extrapolationMode === ExtrapolationMode.SERVER_WEIGHTED ||
       extrapolationMode === ExtrapolationMode.NONE)

static/app/views/alerts/rules/metric/ruleForm.tsx

@@ -792,6 +792,7 @@ class RuleFormContainer extends DeprecatedAsyncComponent<Props, State> {
         const detectionType = detectionTypes.get(comparisonType) ?? '';
         const dataset = this.determinePerformanceDataset();
         this.setState({loading: true});
+        const traceItemType = getTraceItemTypeForDatasetAndEventType(dataset, eventTypes);
         // Add or update is just the PUT/POST to the org alert-rules api
         // we're splatting the full rule in, then overwriting all the data?
         const [data, , resp] = await addOrUpdateRule(
@@ -820,7 +821,12 @@ class RuleFormContainer extends DeprecatedAsyncComponent<Props, State> {
             sensitivity: sensitivity ?? null,
             seasonality: seasonality ?? null,
             detectionType,
-            extrapolationMode: this.isDuplicateRule ? undefined : extrapolationMode,
+            // We want to change the extrapolation mode to unknown once a migrated alert rule is edited
+            extrapolationMode: this.isDuplicateRule
+              ? undefined
+              : getIsMigratedExtrapolationMode(extrapolationMode, dataset, traceItemType)
+                ? ExtrapolationMode.UNKNOWN
+                : extrapolationMode,
           },
           {
             duplicateRule: this.isDuplicateRule ? 'true' : 'false',
@@ -1378,9 +1384,12 @@ class RuleFormContainer extends DeprecatedAsyncComponent<Props, State> {
     const showErrorMigrationWarning =
       !!ruleId && isMigration && ruleNeedsErrorMigration(rule);
 
+    const traceItemType = getTraceItemTypeForDatasetAndEventType(dataset, eventTypes);
+
     const showExtrapolationModeChangeWarning = getIsMigratedExtrapolationMode(
       extrapolationMode,
-      dataset
+      dataset,
+      traceItemType
     );
 
     // Rendering the main form body

static/app/views/alerts/rules/metric/triggers/chart/index.tsx

@@ -46,6 +46,7 @@ import {
 import {capitalize} from 'sentry/utils/string/capitalize';
 import withApi from 'sentry/utils/withApi';
 import {COMPARISON_DELTA_OPTIONS} from 'sentry/views/alerts/rules/metric/constants';
+import {getIsMigratedExtrapolationMode} from 'sentry/views/alerts/rules/metric/details/utils';
 import {
   AlertRuleComparisonType,
   Dataset,
@@ -603,14 +604,20 @@ class TriggersChart extends PureComponent<Props, State> {
       partial: false,
       sampling:
         dataset === Dataset.EVENTS_ANALYTICS_PLATFORM &&
-        this.props.traceItemType === TraceItemDataset.SPANS
-          ? extrapolationMode === ExtrapolationMode.NONE
-            ? SAMPLING_MODE.HIGH_ACCURACY
-            : SAMPLING_MODE.NORMAL
+        traceItemType === TraceItemDataset.SPANS
+          ? getIsMigratedExtrapolationMode(extrapolationMode, dataset, traceItemType)
+            ? SAMPLING_MODE.NORMAL
+            : extrapolationMode === ExtrapolationMode.NONE
+              ? SAMPLING_MODE.HIGH_ACCURACY
+              : SAMPLING_MODE.NORMAL
           : undefined,
 
+      // we want to show the regular extrapolated chart as we are changing the extrapolation to this
+      // once a migrated alert is saved
       extrapolationMode: extrapolationMode
-        ? EAP_EXTRAPOLATION_MODE_MAP[extrapolationMode]
+        ? getIsMigratedExtrapolationMode(extrapolationMode, dataset, traceItemType)
+          ? EAP_EXTRAPOLATION_MODE_MAP[ExtrapolationMode.UNKNOWN]
+          : EAP_EXTRAPOLATION_MODE_MAP[extrapolationMode]
         : undefined,
     };