Skip to content

Commit 9120ec2

Browse files
authored
fix(playstation): Show warning when connection is good, but no errors (#104097)
* Show warning when connection is good, but no errors are available
1 parent 9eb0cff commit 9120ec2

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/sentry/tempest/tasks.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ def fetch_latest_item_id(credentials_id: int, **kwargs) -> None:
7171
if result["latest_id"] is None:
7272
# If there are no crashes in the CRS we want to communicate that back to the
7373
# customer so that they are not surprised about no crashes arriving.
74-
credentials.message = "No crashes found"
75-
credentials.message_type = MessageType.ERROR
74+
credentials.message = "Connection successful. No crashes found in the crash report system yet. New crashes will appear here automatically when they occur."
75+
credentials.message_type = MessageType.WARNING
7676
credentials.save(update_fields=["message", "message_type"])
7777
return
7878
else:

tests/sentry/tempest/test_tempest.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,11 @@ def test_fetch_latest_item_id_task_no_id(self, mock_fetch: MagicMock) -> None:
3333
fetch_latest_item_id(self.credentials.id)
3434

3535
self.credentials.refresh_from_db()
36-
assert self.credentials.message == "No crashes found"
37-
assert self.credentials.message_type == MessageType.ERROR
36+
assert (
37+
self.credentials.message
38+
== "Connection successful. No crashes found in the crash report system yet. New crashes will appear here automatically when they occur."
39+
)
40+
assert self.credentials.message_type == MessageType.WARNING
3841
assert self.credentials.latest_fetched_item_id is None
3942

4043
@patch("sentry.tempest.tasks.fetch_latest_id_from_tempest")

0 commit comments

Comments
 (0)