Skip to content

Conversation

@ameliahsu
Copy link
Member

fixes 2 bugs that were causing the available actions endpoint to return more results than expected:

  • we weren't filtering all sentry apps by is_alertable, causing the webhook action to return extra SentryAppServices that are not alertable
  • we weren't calling prepare_ui_component on the sentry app components, causing us to return broken sentry apps that fail component preparation (see below)
    # TODO(nisanthan): For now, skip showing the UI Component if the API requests fail
    return None

@ameliahsu ameliahsu requested a review from a team as a code owner October 21, 2025 17:26
@ameliahsu ameliahsu changed the title fix(aci): filter out non-alertable or broken sentry apps in available actions endpoint fix(aci): filter out non-alertable and broken sentry apps in available actions endpoint Oct 21, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 21, 2025
cursor[bot]

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #101866    +/-   ##
=========================================
  Coverage   80.98%    80.98%            
=========================================
  Files        8721      8728     +7     
  Lines      387858    388495   +637     
  Branches    24548     24548            
=========================================
+ Hits       314098    314623   +525     
- Misses      73415     73527   +112     
  Partials      345       345            

Comment on lines +96 to +99
prepared_component = prepare_ui_component(
installation=context.installation,
component=context.component,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this component preparation code make any network requests at all?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summarizing a conversation we had in Slack:
This potentially calls the downstream Sentry App's endpoint, which can add a ton of additional latency, or fallibility.

This is ok for now, but we should consider moving this call into its own API, and letting the UI make this call on-demand to retrieve just the UI component that it needs when the user selects the Sentry app as a target and has to configure it.

Additionally, this call is repeated in the serializer below, so we're removing that other call and hoisting it here for now while @ameliahsu works on the API and UI changes.

@getsantry
Copy link
Contributor

getsantry bot commented Nov 19, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Nov 19, 2025
@ameliahsu ameliahsu merged commit 4ac6ca7 into master Nov 19, 2025
71 checks passed
@ameliahsu ameliahsu deleted the mia/aci/fix-alertable-apps branch November 19, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants