feat(trace-tree-node): Replacing legacy TraceTreeNode usage with new BaseNode class #101874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
…-basenode-usage-v3
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| if ( | ||
| !( | ||
| tree.transactions_count < AUTO_EXPAND_TRANSACTIONS_THRESHOLD || | ||
| tree.collapsed_nodes < AUTO_EXPAND_TRANSACTIONS_THRESHOLD || |
Contributor
There was a problem hiding this comment.
Bug: Trace Expansion Logic Incorrect
The trace auto-expansion logic now incorrectly uses tree.collapsed_nodes instead of tree.transactions_count to determine if a trace has few transactions. This can cause traces to auto-expand when they shouldn't or fail to expand when they should, potentially impacting performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy
TraceTreeNodeclass and it's subclasses from the codebase.Also, replaces the use of
TraceTreestatics methods with the newBaseNodemethodsNote that this PR, doesn't replace the use of guards or doesn't fully use the generalizations introduced by the new
BaseNodeclass. The goal is to make the minimal amount of change to reach feature parity, pass CI and get rid of the legacyTraceTreeNodeclass.I will be following up with a stacked PR to make full use of the BaseNode class, mitigate the use of guards etc. Helps make reviewing easier/reduces scope.
At this stack all CI passes ✅, we can merge into master