chore(member merge): clean up users without email addresses #101981
+82
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mifu67
changed the base branch from
master
to
mifu67/member-merge/sentry-app-proxy-user-email-backfill-self-hosted
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| @control_silo_test | ||
| @override_settings(SENTRY_SELF_HOSTED=True) | ||
| class BackfillSelfHostedSentryAppEmailsTest(TestMigrations): |
Contributor
There was a problem hiding this comment.
Bug: Test Class Name Mismatch
The test class BackfillSelfHostedSentryAppEmailsTest has an incorrect name. This looks like a copy-paste from the 0997 migration test. The class is actually validating the 0998 migration, which deletes never-active users without emails, so the current name doesn't accurately reflect its purpose.
vgrozdanic
approved these changes
Oct 23, 2025
cathteng
approved these changes
Oct 29, 2025
markstory
approved these changes
Oct 29, 2025
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of https://github.com/getsentry/getsentry/pull/17549 using a migration for self-hosted users.