-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore: Remove empty /manage/ admin overview #102988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The admin overview page is empty now. Instead of the default view of `/manage/` being an empty view we can show the environment page instead.
| { | ||
| index: true, | ||
| component: make(() => import('sentry/views/admin/adminOverview')), | ||
| component: make(() => import('sentry/views/admin/adminEnvironment')), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Routing Redundancy Impairs Navigation Consistency.
The index route at /manage/ now renders adminEnvironment, but there's also an explicit route at /manage/status/environment/ that renders the same component. This creates duplicate routes for the same content and causes navigation inconsistency—when viewing /manage/, the "Environment" navigation item won't highlight as active since it expects /manage/status/environment/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we fix this?
aldy505
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have write access 😅
The admin overview page is empty now. Instead of the default view of `/manage/` being an empty view we can show the environment page instead.
The admin overview page is empty now. Instead of the default view of `/manage/` being an empty view we can show the environment page instead.
The admin overview page is empty now. Instead of the default view of
/manage/being an empty view we can show the environment page instead.