feat(np): Update frontend to support new body blocks #103001
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| </Text> | ||
| {displayFormat === ExampleDataFormat.FORMATTED ? ( | ||
| <Text>{registration.example.body}</Text> | ||
| <Text>{JSON.stringify(registration.example.body)}</Text> |
Contributor
There was a problem hiding this comment.
Bug: Formatted Body View Displays Raw JSON.
The formatted display mode for body incorrectly shows JSON.stringify(registration.example.body) instead of rendering the body blocks properly. Since body is now NotificationBodyFormattingBlock[] instead of a string, the formatted view should use NotificationBodyRenderer to display the content, while only the raw view should show the stringified JSON.
Contributor
Author
There was a problem hiding this comment.
I believe this is for the sidebar so we should render as a JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the frontend to process the blocks for the previews
What is looks like -
relies on #102975