chore(explorer): reduce spans per trace to 1000 #103010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103010 +/- ##
===========================================
- Coverage 80.75% 80.64% -0.11%
===========================================
Files 9145 9140 -5
Lines 395020 392793 -2227
Branches 24968 24968
===========================================
- Hits 319002 316773 -2229
- Misses 75617 75619 +2
Partials 401 401 |
JoshFerge
approved these changes
Nov 10, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| orderby=["precise.start_ts"], | ||
| offset=0, | ||
| limit=5000, | ||
| limit=1000, |
Contributor
There was a problem hiding this comment.
Bug: Incorrect Span Count Misleads Consumers
The total_spans field in the returned TraceData object is set to len(spans), but with the limit reduced to 1000, traces with more than 1000 spans will have an incorrect total_spans value that only reflects the number of fetched spans rather than the actual total. This misleads consumers like Seer and logging that rely on this metric.
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
Reduce the max spans we fetch per transaction from 5000 to 1000. This should reduce bytes scanned, and for 99% of traces this has no effect.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Reduce the max spans we fetch per transaction from 5000 to 1000. This should reduce bytes scanned, and for 99% of traces this has no effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the max spans we fetch per transaction from 5000 to 1000. This should reduce bytes scanned, and for 99% of traces this has no effect.