-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(aci): remove detector usage in WorkflowFireHistory and action firing #103082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
| total_actions += len(filtered_actions) | ||
|
|
||
| fire_actions(filtered_actions, detector, workflow_event_data) | ||
| fire_actions(filtered_actions, workflow_event_data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Invalid Events Trigger Failing Actions
Removing the detector existence check allows workflow fire histories to be created and actions to be triggered for events without detectors. Previously, events missing detectors were skipped with a warning. Now, trigger_action tasks will be queued and fail when get_detector_by_event raises Detector.DoesNotExist, causing unnecessary task failures and retries instead of gracefully handling missing detectors upfront.
|
|
||
| if detector is None: | ||
| detector = get_detector_by_event(event_data) | ||
| detector = get_detector_by_event(event_data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Activity Actions Fail: Detector Type Mismatch
The unconditional call to get_detector_by_event raises TypeError for Activity events since it only supports GroupEvent. Previously, the detector was passed via detector_id parameter, avoiding this call for Activity-triggered actions. Now Activity events that trigger actions will fail when the async task attempts to fetch the detector.
Title
Should merge #102918 first. Also removes need for
get_detectors_by_groupevents_bulk!