Skip to content

feat(sub v3): Surface account balance and card brand #103094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 13, 2025
Merged

feat(sub v3): Surface account balance and card brand #103094

merged 7 commits into from
Nov 13, 2025

Conversation

@isabellaenriquez
Copy link
Member

@isabellaenriquez isabellaenriquez commented Nov 10, 2025 •
edited
Loading

Closes BIL-1731 and BIL-1732.

  • Adds account balance to Billing Info card
  • Adds card brand to Billing Info card and Billing Info page
  • Corrects types

Needs https://github.com/getsentry/getsentry/pull/18796

billing info page

Screenshot 2025-11-10 at 4 05 10 PM

billing info card on overview page

Screenshot 2025-11-10 at 4 05 01 PM

@linear
Copy link

linear bot commented Nov 10, 2025

BIL-1731 Surface non-zero account balance in billing info card

BIL-1732 Surface card brand in billing info UI

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12586 1 12585 10
View the top 1 failed test(s) by shortest run time 
Billing details form displays credit card expiration date
Stack Traces | 0.147s run time 
TypeError: Cannot read properties of undefined (reading 'replace')
    at replace (.../utils/string/toTitleCase.tsx:10:14)
    at CreditCardPanel (.../components/creditCardEdit/panel.tsx:192:34)
    at Object.react_stack_bottom_frame (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:25904:20)
    at renderWithHooks (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:7662:22)
    at updateFunctionComponent (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:10166:19)
    at beginWork (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:11778:18)
    at runWithFiberInDEV (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:874:13)
    at performUnitOfWork (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:17641:22)
    at workLoopSync (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:17469:41)
    at renderRootSync (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:17450:11)
    at performWorkOnRoot (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:16583:35)
    at performWorkOnRootViaSchedulerTask (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:18957:7)
    at flushActQueue (.../sentry/node_modules/.pnpm/[email protected]..../react/cjs/react.development.js:590:34)
    at process.env.NODE_ENV.exports.act (.../sentry/node_modules/.pnpm/[email protected]..../react/cjs/react.development.js:884:10)
    at .../sentry/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@type_011f94990cdc27509fa142ae9e3c3bf5/node_modules/@.../react/dist/act-compat.js:47:25
    at renderRoot (.../sentry/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@type_011f94990cdc27509fa142ae9e3c3bf5/node_modules/@.../react/dist/pure.js:188:26)
    at Object.render (.../sentry/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@type_011f94990cdc27509fa142ae9e3c3bf5/node_modules/@.../react/dist/pure.js:287:10)
    at render (.../js/sentry-test/reactTestingLibrary.tsx:429:28)
    at Object.<anonymous> (.../views/subscriptionPage/billingInformation.spec.tsx:639:11)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1009:40)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:520:9)
    at _runTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:494:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@isabellaenriquez isabellaenriquez marked this pull request as ready for review November 12, 2025 15:20
@isabellaenriquez isabellaenriquez requested a review from a team as a code owner November 12, 2025 15:20
cursor[bot]
cursor bot reviewed Nov 12, 2025
View reviewed changes
isabellaenriquez
isabellaenriquez commented Nov 12, 2025
View reviewed changes
static/gsApp/types/index.tsx
Comment on lines +381 to +386
brand: string;
countryCode: string | null;
expMonth: number;
expYear: number;
last4: string;
zipCode: string;
zipCode: string | null;
Copy link
Member Author

@isabellaenriquez isabellaenriquez Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the logic we use to create PaymentMethod, only zip code or country code can be null

@isabellaenriquez isabellaenriquez merged commit 0b8fee7 into master Nov 13, 2025
47 checks passed
@isabellaenriquez isabellaenriquez deleted the isabella/surface-info branch November 13, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@vbro vbro vbro approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isabellaenriquez @vbro