Skip to content

Conversation

@DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Nov 20, 2025

  1. Auto populate dashboard ids in prebuilt dashboards when linking to another prebuilt dashboard
  2. Update temporary global filters to account for duplicates

@DominikB2014 DominikB2014 requested review from a team as code owners November 20, 2025 17:43
@linear
Copy link

linear bot commented Nov 20, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2025
if (dasboardId) {
linkedDashboard.dashboardId = dasboardId;
}
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Mutation of static dashboard configuration

The code directly modifies properties of linkedDashboard objects within the component body. Since these objects reference the static PREBUILT_DASHBOARDS configuration, this side effect persists globally, potentially causing incorrect dashboard IDs to persist across organization changes. Side effects should not occur during render; use state or memoization to handle the updated data.

Fix in Cursor Fix in Web

@DominikB2014 DominikB2014 marked this pull request as draft November 20, 2025 20:46
@DominikB2014 DominikB2014 enabled auto-merge (squash) November 21, 2025 20:12
@DominikB2014 DominikB2014 merged commit 3c83451 into master Nov 21, 2025
49 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/browse-127-automatically-fetch-and-populate-dashboardid-in-dashboard branch November 21, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants