-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(dashboards): automatically populate dashboard ids in prebuilt dashboards #103738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboards): automatically populate dashboard ids in prebuilt dashboards #103738
Conversation
| if (dasboardId) { | ||
| linkedDashboard.dashboardId = dasboardId; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Mutation of static dashboard configuration
The code directly modifies properties of linkedDashboard objects within the component body. Since these objects reference the static PREBUILT_DASHBOARDS configuration, this side effect persists globally, potentially causing incorrect dashboard IDs to persist across organization changes. Side effects should not occur during render; use state or memoization to handle the updated data.
Uh oh!
There was an error while loading. Please reload this page.