-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(issues): better top issue tooling #103984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| const BATCH_SIZE = 50; | ||
|
|
||
| /** Fetches issue stats for clusters in batches to avoid API limits. */ | ||
| function useBatchClusterStats(clusters: ClusterSummary[]): { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be good to split this hook out into a separate file for readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea — i'm going to actually split this PR up a bit as well, so this will live in a separate file
| </Flex> | ||
|
|
||
| <ClusterStatsBar> | ||
| {cluster.fixability_score && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if it would make sense for the fixability score to be 0 but maybe safer to check for nullness here instead of general falsiness?
1e40ad9 to
bb07727
Compare
| {t('confidence')} | ||
| </Text> | ||
| </StatItem> | ||
| )} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Fixability score zero incorrectly hidden from display
The condition {cluster.fixability_score && ( uses a truthiness check that treats 0 as falsy, preventing the fixability score component from rendering when the score is exactly 0. Since fixability_score is number | null, a value of 0 represents a valid 0% confidence score that should be displayed. Use a nullness check (!= null or !== null) instead of truthiness to distinguish between the missing value (null) and a valid zero score.
Add custom sorting logic so we can sort by cluster recency, # of events, fixability, and # of issues, or any combination of these factors.