Skip to content

Conversation

@cvxluo
Copy link
Contributor

@cvxluo cvxluo commented Nov 25, 2025

Add custom sorting logic so we can sort by cluster recency, # of events, fixability, and # of issues, or any combination of these factors.

@cvxluo cvxluo changed the base branch from master to cvxluo/top-issue-debug-functions November 25, 2025 17:43
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 25, 2025
@cvxluo cvxluo changed the title ref(issues): better top issue tooling feat(issues): better top issue tooling Nov 25, 2025
@cvxluo cvxluo marked this pull request as ready for review November 25, 2025 17:48
@cvxluo cvxluo requested a review from a team as a code owner November 25, 2025 17:48
@cvxluo cvxluo requested a review from a team November 25, 2025 17:48
const BATCH_SIZE = 50;

/** Fetches issue stats for clusters in batches to avoid API limits. */
function useBatchClusterStats(clusters: ClusterSummary[]): {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be good to split this hook out into a separate file for readability

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea — i'm going to actually split this PR up a bit as well, so this will live in a separate file

</Flex>

<ClusterStatsBar>
{cluster.fixability_score && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it would make sense for the fixability score to be 0 but maybe safer to check for nullness here instead of general falsiness?

Base automatically changed from cvxluo/top-issue-debug-functions to master November 25, 2025 19:36
@cvxluo cvxluo force-pushed the cvxluo/better-top-issue-tooling branch from 1e40ad9 to bb07727 Compare November 25, 2025 19:59
{t('confidence')}
</Text>
</StatItem>
)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Fixability score zero incorrectly hidden from display

The condition {cluster.fixability_score && ( uses a truthiness check that treats 0 as falsy, preventing the fixability score component from rendering when the score is exactly 0. Since fixability_score is number | null, a value of 0 represents a valid 0% confidence score that should be displayed. Use a nullness check (!= null or !== null) instead of truthiness to distinguish between the missing value (null) and a valid zero score.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants