-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(aci): redirect to alert rules when UI FF is off #97583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| !user.isStaff && !organization.features.includes('workflow-engine-ui'); | ||
|
|
||
| if (shouldRedirect) { | ||
| navigate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React doesn't like side-effects being called by the render function. Usually we'd put this in a useEffect, but we have a Redirect component that you can return here instead that would be best
|
Should we remove the |
e30576f to
e5d511c
Compare
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mia/aci/get-alertrule-workflow #97583 +/- ##
==================================================================
+ Coverage 80.66% 80.68% +0.01%
==================================================================
Files 8547 8550 +3
Lines 376144 376253 +109
Branches 24443 24443
==================================================================
+ Hits 303422 303567 +145
+ Misses 72350 72314 -36
Partials 372 372 |
e5d511c to
933da60
Compare
e9f1b1a to
98e26d5
Compare
| export default function AutomationEdit() { | ||
| const params = useParams<{automationId: string}>(); | ||
|
|
||
| useWorkflowEngineFeatureGate({redirect: true}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also call this on DetectorViewContainer which is the top level component for automations and detectors, so I think we need to remove it on that file as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the callout, I'll wait until I have all of the detector redirects set up to safely remove it on the DetectorViewContainer
Uh oh!
There was an error while loading. Please reload this page.